That bug stayed hidden in implicit AnsiChar for years...

-
That bug stayed hidden in implicit AnsiChar for years...
http://www.delphitools.info/2013/11/18/unicode-leftover-bug-from-hell/

Comments

  1. Eugene Mayevski (Риба Баскервілей)November 18, 2013 at 1:20 AM

    The conclusion - it's always safer to use constructs like `if ord(MyChar) <= 255` .

    ReplyDelete
  2. Eric GrangeNovember 18, 2013 at 1:44 AM

    Eugene Mayevski Not really, if you do that, you move the problem to the Ord() and the MyChar encoding, as your 255 is then constant, but meaningless on its own.
    The compiler could have warned about the implicit conversion and the range for the set (like it does if you use the 4 digit notation), or better, they could have extended sets to work in the UCS2 range (ie. WideChar), which would also have avoided the CharInSet() kludge.

    ReplyDelete
  3. Eugene Mayevski (Риба Баскервілей)November 18, 2013 at 1:50 AM

    In case of ord() the charset conversion is under your control.

    ReplyDelete

Post a Comment