People, I am calling an external DLL function into my code. One of the parameters is the Filename, so the function parameter expects a PAnsiChar() / convertion. All look likes to be fine, but the generated file gets only the 1st char, so if name it "myfile.dat" I will see a "m" file on the folder.

-
People, I am calling an external DLL function into my code. One of the parameters is the Filename, so the function parameter expects a PAnsiChar() / convertion. All look likes to be fine, but the generated file gets only the 1st char, so if name it "myfile.dat" I will see a "m" file on the folder.
I am using XE5. Should I call the procedure developer for help? That DLL can be used in a lot of examples, since C# to Java, including Delphi.
Thank you.

Comments

  1. Nándor KissJune 24, 2014 at 2:05 PM

    Do You use "stdcall" on the external?

    ReplyDelete
  2. Nicholas RingJune 24, 2014 at 2:16 PM

    Just to cover the obvious but you are passing the file name by PAnsiChar(filename), right?

    ReplyDelete
  3. Magno LimaJune 24, 2014 at 3:50 PM

    Yes: function thefunction(FileName: PAnsiChar): integer; cdecl; external 'thedll.dll'; and Yes, PAnsiChar(filename) :)

    ReplyDelete
  4. André MusscheJune 24, 2014 at 10:50 PM

    Do you have compiler warnings or hints? I think it should be: PAnsichar(ansistring(filename))

    ReplyDelete
  5. Dorin DuminicaJune 24, 2014 at 11:31 PM

    André Mussche is on the ball here, you have a unicode string that you're trying to pass as a ansi string pointer, however, data at PAnsiChar(fileName) looks:

    [m] [0x00] [y] [0x00] ...

    since the second byte is NULL, that's where the DLL stops to read all other bytes in your file name.

    ReplyDelete
  6. Magno LimaJune 25, 2014 at 3:56 AM

    André Mussche Yes man, that did the trick. Unicode issue :)  Thank you

    ReplyDelete
  7. André MusscheJune 25, 2014 at 4:01 AM

    Magno Lima Nice :), but for me, the important question is: did delphi complain about a "suspicious ansistring conversion" or something like that?

    ReplyDelete
  8. Magno LimaJune 25, 2014 at 4:58 AM

    YES! Blame on me! :)
    [dcc32 Warning] uMain.pas(256): W1044 Suspicious typecast of string to PAnsiChar

    ReplyDelete
  9. André MusscheJune 25, 2014 at 5:06 AM

    Magno Lima Right :) No kidding: always make sure you have no hints or warnings!

    ReplyDelete
  10. Lars FosdalJune 25, 2014 at 5:12 AM

    Hints are just messy, while warnings are a sign of a clear and present danger.

    ReplyDelete
  11. Magno LimaJune 25, 2014 at 5:32 AM

    Thank you for advise! :)

    ReplyDelete
  12. Daniela OsterhagenJune 25, 2014 at 10:35 AM

    Lars Fosdal Hints can tell you very important things too, e.g. you declare a variable called "MyName" but later on by mistake use the property "Name" instead. The compiler will hint you, that the variable is declared but never used.

    ReplyDelete
  13. Lars FosdalJune 25, 2014 at 12:11 PM

    Daniela Osterhagen - That is true.  I prefer to keep my code hint and warning free, but when cleaning out someone elses code, it is the warnings that take prio.

    ReplyDelete
  14. Asbjørn HeidJune 25, 2014 at 5:55 PM

    Meanwhile a successful build here produces some 10k warnings and hints... It's my summer mission to do something about that...

    ReplyDelete
  15. Lars FosdalJune 25, 2014 at 11:44 PM

    How many LOC in that build?

    ReplyDelete
  16. Dorin DuminicaJune 26, 2014 at 1:32 AM

    Lars Fosdal probably too many for a stable IDE ((:
    On one of my 50k+ LOC the IDE fails to start auto-complete and all kinds of artifacts appear all over the place...

    ReplyDelete
  17. Lars FosdalJune 26, 2014 at 2:04 AM

    We have a 600k+ line project, and it has artifacts (such as a unit with no blue dots for generated code), but auto-complete seems to keep working.

    ReplyDelete
  18. Dorin DuminicaJune 26, 2014 at 2:13 AM

    Lars Fosdal 600k+ just project code, or the sum with used components?

    I wonder if my issue has anything to do with the fact that there are over 200 units in the project...?

    ReplyDelete
  19. Magno LimaJune 26, 2014 at 5:08 AM

    Actually I try dont care for warnings out of my own code, ie. 3rd party comps, unless I see it will cause any trouble or avoid it to compile...

    ReplyDelete
  20. André MusscheJune 26, 2014 at 5:21 AM

    Magno Lima but it is easier to spot problems early if you have no hints and warnings at all and suddenly you get a warning or hint... (my colleague even has turned on "error on hints and warnings"!)

    ReplyDelete
  21. Asbjørn HeidJune 26, 2014 at 5:40 AM

    Lars Fosdal I haven't done a proper count, I'm guessing about 200kLOC of our own. When building it goes to about 500kLOC, but I think that includes the JCL units we use and such things.

    ReplyDelete
  22. Lars FosdalJune 26, 2014 at 5:53 AM

    Dorin Duminica - around 150K lines are project specific in the server.  Around 250K in the client app.

    ReplyDelete
  23. Dorin DuminicaJune 26, 2014 at 5:57 AM

    Lars Fosdal still a ton (: I've used CnPack in D2010 which has a plugin(?) capable of doing all the project source counts, so, effective code(no empty lines, no comments, etc.) was around 5XK LOC, since then, we've moved to XE6, there was no CnPack at the time, so I have no idea of exact count at this time, however, it's only growing (:

    ReplyDelete

Post a Comment