I wonder why you did not just create a fork, commited the changes so one can easily see what you did instead of having to download (or watching it online) a zip and clicking through the entire folder structure. And once the official release is out one could just simply reset to the official commit.
The reason I didn't fork and commit the changes, is that I really didn't spend too much time on it - I just wanted to make it work at my end for the mock-up and then someone (which then could end up being me - if no one is currently working on this) - could then give it a bit more work also doing the dprojs and the devtool part if needed. Someone who had worked with the JVCL/JCL installer before would have an easier job. The feature request could be GetIt suport :-)
Creating a fork is less work than creating a zip with the changed files I guess (at least if you already have a github account which also is a matter of seconds to set up). I am just bringing that up because many people still seem to be very unfamiliar with git and how you efficiently work with it.
Stefan, I agree with you - and I do use both github and bitbucket (and git in general) - and I also did a blog ranting about why there are still people out there not using some king of (D)VCS. I have just been a simple user of JVCL - and wasn't aware that there was a XE8 feature request posted as David mentioned - I can't add the zip file and I shouldn't - but I should do as you suggests - fork and finish of the work - when time permits - meanwhile people got aware that XE8 and JVCL exists :-)
Great to have an update to JCL/JVCL. We'd be interested in hosting them in GetIt. Just need someone from the team email me, I can forward the steps for submission (will be automated in the future)
Marco Cantù I just did a feature request http://issuetracker.delphi-jedi.org/view.php?id=6401, so that someone knows what they are doing can contact you :-) I can see that proper support for XE8 is being worked on - if not already done in the repository.
I wonder why you did not just create a fork, commited the changes so one can easily see what you did instead of having to download (or watching it online) a zip and clicking through the entire folder structure. And once the official release is out one could just simply reset to the official commit.
ReplyDeleteNice work! I don't suppose you could attach your patch to http://issuetracker.delphi-jedi.org/view.php?id=6399 please? It's a bug / feature request for XE8 support in the JVCL.
ReplyDeleteDavid Millington I guess there are enough Jedi people in the beta to have that worked that out by now but not yet merged back :)
ReplyDeleteThe reason I didn't fork and commit the changes, is that I really didn't spend too much time on it - I just wanted to make it work at my end for the mock-up and then someone (which then could end up being me - if no one is currently working on this) - could then give it a bit more work also doing the dprojs and the devtool part if needed. Someone who had worked with the JVCL/JCL installer before would have an easier job. The feature request could be GetIt suport :-)
ReplyDeleteCreating a fork is less work than creating a zip with the changed files I guess (at least if you already have a github account which also is a matter of seconds to set up). I am just bringing that up because many people still seem to be very unfamiliar with git and how you efficiently work with it.
ReplyDeleteStefan, I agree with you - and I do use both github and bitbucket (and git in general) - and I also did a blog ranting about why there are still people out there not using some king of (D)VCS. I have just been a simple user of JVCL - and wasn't aware that there was a XE8 feature request posted as David mentioned - I can't add the zip file and I shouldn't - but I should do as you suggests - fork and finish of the work - when time permits - meanwhile people got aware that XE8 and JVCL exists :-)
ReplyDeleteGreat to have an update to JCL/JVCL. We'd be interested in hosting them in GetIt. Just need someone from the team email me, I can forward the steps for submission (will be automated in the future)
ReplyDeleteMarco Cantù I just did a feature request http://issuetracker.delphi-jedi.org/view.php?id=6401, so that someone knows what they are doing can contact you :-) I can see that proper support for XE8 is being worked on - if not already done in the repository.
ReplyDelete