Emba needs to get a grip on unit testing.

-
Emba needs to get a grip on unit testing.
TComparer> is broken when testing empty arrays.

Just filed: https://quality.embarcadero.com/browse/RSP-11310
https://quality.embarcadero.com/browse/RSP-11321 as well as
https://quality.embarcadero.com/browse/RSP-11301 
https://quality.embarcadero.com/browse/RSP-11310

Comments

  1. Johan BontesJune 13, 2015 at 3:12 AM

    8-byte records compare different between x64 and x32: https://quality.embarcadero.com/browse/RSP-11321 
    Also the variant comparisons also fail in very subtle ways. Correction my variant comparison failed, emba's works.

    That's 3 bugs in just the Default.Compare code...

    ReplyDelete
  2. David HeffernanJune 13, 2015 at 4:17 AM

    It's folly using the default comparer with a record, IMHO. But yeah, the different compilers should be consistent.

    ReplyDelete
  3. Johan BontesJune 13, 2015 at 10:09 AM

    Note that the 8-byte record comparer is also used for sets and static arrays and some other things.

    ReplyDelete

Post a Comment