Damned !

-
Damned !

var
Comp : function(const s1, s2: string): Boolean;
begin
if CheckBox1.Checked then
Comp := ContainsText
else
Comp := AnsiStartsText;

why are the parameters in a reverse order !!!

Comments

  1. Primož GabrijelčičDecember 13, 2016 at 8:09 AM

    Life is hard ;)

    var
    Comp : function(const s1, s2: string): Boolean;
    begin
    if CheckBox1.Checked then
    Comp := ContainsText
    else
    Comp := function(const s1, s2: string): Boolean begin Result := AnsiStartsText(s2,s1); end;

    ReplyDelete
  2. Paul TOTHDecember 13, 2016 at 8:12 AM

    I feel like a PHP developper just now :)

    ReplyDelete
  3. Jeroen Wiert PluimersDecember 13, 2016 at 9:53 AM

    This is one of my main gripes about lots of RTL/VCL/FMX code: conventions are often lacking.

    ReplyDelete
  4. Paul TOTHDecember 14, 2016 at 2:47 AM

    Primož Gabrijelčič you can't mix reference and function ... and you can't decalre a reference type without a type ...

    type
    TComp = reference to function(const s1, s2: string):Boolean;
    var
    Comp : TComp;
    begin
    if CheckBox1.Checked then
    Comp := function(const s1, s2: string): Boolean begin Result := ContainsText(s1,s2); end
    else
    Comp := function(const s1, s2: string): Boolean begin Result := AnsiStartsText(s2,s1); end;

    ReplyDelete
  5. Primož GabrijelčičDecember 14, 2016 at 5:01 AM

    Indeed, I didn't test it. One has to do it your way.

    ReplyDelete
  6. David MillingtonDecember 15, 2016 at 2:57 AM

    We could introduce new methods that follow one convention. Enter a QP.

    ReplyDelete
  7. Paul TOTHDecember 15, 2016 at 3:16 AM

    David Millington https://quality.embarcadero.com/browse/RSP-16549

    ReplyDelete
  8. Paul TOTHNovember 27, 2017 at 3:55 AM

    David Millington "Works As Expected"

    ReplyDelete
  9. David MillingtonNovember 27, 2017 at 4:33 AM

    Paul TOTH I see it was "expected" because you can't change the order of params of existing methods (which is fair) - but it ignored adding a new one. Please click "Dispute resolution" and maybe add a comment why. I've reopened it internally already.

    ReplyDelete
  10. Jeroen Wiert PluimersNovember 27, 2017 at 4:52 AM

    My frustration with issues like these isn't the resolution, but that it takes almost a year to get a response at all.

    ReplyDelete
  11. Paul TOTHNovember 27, 2017 at 6:40 AM

    a QP has never changed as fast as this one...G+ effect ?

    ReplyDelete
  12. Thaddy de KoningJanuary 10, 2018 at 8:36 AM

    comp is a type.. This hurts my eyes....

    ReplyDelete
  13. Rudy VelthuisJanuary 13, 2018 at 12:45 PM

    David Millington Of course it is not really rocket science to write a simple wrapper that reverses the parameters, either. That is what I would do, instead of relying on others to fix this.

    ReplyDelete

Post a Comment