The code state of an exiting Delphi based product.

-
The code state of an exiting Delphi based product.

With copy-paste lowercase code blocks https://www.dropbox.com/s/hwpzpfkfzahrk4d/Screenshot%202016-12-08%2009.00.50.png?raw=1 and of course everybody knows what form21 is for in https://www.dropbox.com/s/rkeebbyygg9dvhj/Screenshot%202016-12-08%2009.02.53.png?raw=1

Granted there is TTabedForm which then uses TabControl1 and TabControl2 for clarity: https://www.dropbox.com/s/zubus0egfhksnt7/Screenshot%202016-12-08%2009.04.15.png?raw=1

Originally shared by Delphi

Bluetooth LE enabled ultraviolet light sensor embedded in swimwear, connected to app on mobile device. Powered by Delphi and InterBase IBLite.
.
http://embt.co/2gEjLu2
http://embt.co/2gEjLu2

Comments

  1. Roald van DoornDecember 8, 2016 at 12:30 AM

    Those screenshots should be used for a game of "Count the codesmells"...

    ReplyDelete
  2. Lars FosdalDecember 8, 2016 at 12:33 AM

    Loved the commented out try sql code with the empty except block :)

    Also,
    if not condition
    then begin
    form.component1.visible := true;
    form.component2.visible := false;
    end
    else begin
    form.component2.visible := true;
    form.component1.visible := false;
    end;

    instead of

    form.component1.visible := not condition;
    form.component2.visible := condition;

    It might be that the order is important, though - but, well....

    ReplyDelete
  3. Andreas SchachtnerDecember 8, 2016 at 1:39 AM

    ... checked = false!

    ReplyDelete
  4. Uwe RaabeDecember 8, 2016 at 2:39 AM

    Perhaps the developers were just distracted.

    ReplyDelete
  5. Dorin DuminicaDecember 8, 2016 at 5:31 AM

    Lars Fosdal I doubt that the order of changing visibility impacts anything, but OK (;

    #paybyloc

    ReplyDelete
  6. Kyle MillerDecember 8, 2016 at 8:10 AM

    They're protecting intellectual property by deceiving you with fake code. Just a prop.

    ReplyDelete
  7. mezenDecember 8, 2016 at 9:21 AM

    And I thought I was the only nerd who looked at the source code in that video^^

    ReplyDelete
  8. Jeroen Wiert PluimersDecember 8, 2016 at 10:30 AM

    Attila Kovacs apparently Necchi is out (:

    ReplyDelete
  9. Dorin DuminicaDecember 8, 2016 at 10:45 AM

    Kyle Miller maaaaaaaybe so, maaaaaybe marketing didn't sync with devs? (;

    ReplyDelete
  10. Daniela OsterhagenDecember 8, 2016 at 12:09 PM

    Lars Fosdal using an if statement like this can improve readability. I would have made that a property or method of the form though.

    ReplyDelete
  11. Alexandre MachadoDecember 8, 2016 at 3:27 PM

    Come on guys. Terminator (you know, Arnold Schwarzenegger movie...) was running on Apple II crappy software and I didn't see you guys pointing the finger...

    ReplyDelete
  12. Jack WuDecember 14, 2016 at 10:15 PM

    Lars Fosdal
    if ladies then
    Beautiful := true
    Else if Delphi then
    Begin
    Older := true;
    Disadvantage := true;
    Expensive := true;
    Manybugs := true;
    Beauties := faint;
    End;

    ReplyDelete

Post a Comment