Merged more contributions from Hallvard Vassbotn and added some fixes on top of those https://github.com/jpluimers/HVRTTIUtils/commit/085435202b26f02da7f7cdf62fbf1627a18b9178

-
Merged more contributions from Hallvard Vassbotn and added some fixes on top of those https://github.com/jpluimers/HVRTTIUtils/commit/085435202b26f02da7f7cdf62fbf1627a18b9178

HVassbotn: Fix #9 and optimise speed comparisons
- Fixes EAssertionFailed with message 'Instance.ClassType TMyDescendent2 <> TMyClass TMyClass
- IFOPT C for code needed by Asserts
- Promoted fix to TestDmt project
- Tried to fix the speed comparisons by repeating tests twice and disabling AddState
- fixed memory leaks
- typo fix MPlusTests -> TMPlusTests
- removed dead code

Continuation of https://plus.google.com/u/0/+JeroenPluimers/posts/QZ2bR6DmHo8
https://github.com/jpluimers/HVRTTIUtils/commit/085435202b26f02da7f7cdf62fbf1627a18b9178

Comments

  1. David HeffernanMarch 20, 2017 at 3:27 PM

    Why do we need to see a post here every time you make a commit?

    ReplyDelete
  2. Jeroen Wiert PluimersMarch 21, 2017 at 12:21 AM

    Hopefully others will start helping too (:

    ReplyDelete
  3. David HeffernanMarch 21, 2017 at 1:10 AM

    That's fine, but I don't see any reason for you to spam us.

    ReplyDelete
  4. Lars FosdalMarch 21, 2017 at 1:47 AM

    Three different projects, and 19 weeks since the last post in the I made this category, hardly qualifies Jeroen as a spammer, IMO.

    ReplyDelete
  5. David HeffernanMarch 21, 2017 at 1:55 AM

    Lars Fosdal One project (https://github.com/jpluimers/HVRTTIUtils/commits/develop), three posts, as I see it. Seems like a new post to this group for each commit. If we want to follow the commits, github has mechanisms for that, should we choose to be interested.

    ReplyDelete
  6. Lars FosdalMarch 21, 2017 at 2:12 AM

    David Heffernan To be able to do that, you would need to be aware of the project. Perhaps he could have done it in one post - but I applaud his efforts in open source. More people should contribute in that way, myself included.

    ReplyDelete
  7. Stefan GlienkeMarch 21, 2017 at 2:49 AM

    If I may comment on the subject itself, putting your own changes into a merge commit is not the best way to do as it is hard to keep track of what actually was done by the person putting the PR and another person (you).
    Like it took me a moment to see that you solve the issue with AddState by adding that bool FSkipAddState. Also I wonder why it calls Measure two times.

    ReplyDelete
  8. Jeroen Wiert PluimersMarch 21, 2017 at 4:25 AM

    Stefan Glienke I agree. And it measures twice so the first time ensure caching and other optimisations can be set up.

    ReplyDelete

Post a Comment