WTF !!!!

-
WTF !!!!

FMX.Forms.Border.Win contains a private global var

var
Rts: array [0..5000] of TRect;

80.016 bytes !

Comments

  1. Dorin DuminicaJune 10, 2017 at 9:39 AM

    x, y, w, h are they single or double?

    ReplyDelete
  2. Agustin OrtuJune 10, 2017 at 10:00 AM

    /sub

    ReplyDelete
  3. Willem WeidemanJune 10, 2017 at 10:29 AM

    /sub

    ReplyDelete
  4. Paul TOTHJune 10, 2017 at 12:04 PM

    Dorin Duminica 4 * SizeOf(Integer) * 50001 = 80.016 I've discovered that looking at TDS infos

    FMX.Forms.Border.Win data size is exactly 80.016

    github.com - Delphi

    ReplyDelete
  5. Nicholas RingJune 10, 2017 at 12:36 PM

    That's a very interesting project. Thanks for sharing.

    Note. Typo in the above formula. You have 50,001 instead of 5,001. But I get your point

    ReplyDelete
  6. Dorin DuminicaJune 10, 2017 at 12:44 PM

    Paul TOTH interesting that it's using ints rather than floats

    ReplyDelete
  7. Nicholas RingJune 10, 2017 at 1:08 PM

    Attila Kovacs​ you could just clone it with https://github.com/tothpaul/Delphi.git

    ReplyDelete
  8. Dalija PrasnikarJune 10, 2017 at 1:45 PM

    Dorin Duminica AFAIK that array is used to create Windows region from bitmap on Windows and API requires integer coordinates.

    ReplyDelete
  9. Dorin DuminicaJune 10, 2017 at 1:57 PM

    Dalija Prasnikar right, I missed the Win suffix, makes sense, thanks!

    ReplyDelete
  10. Paul TOTHJune 11, 2017 at 2:40 AM

    it should be a local dynamic array of TRect not a global var.

    ReplyDelete
  11. Paul TOTHJune 11, 2017 at 2:41 AM

    Attila Kovacs on the main page you can download everystring as a single ZIP...but you can't download a branch AFAIK
    github.com - tothpaul/Delphi

    ReplyDelete
  12. Dalija PrasnikarJune 11, 2017 at 2:50 AM

    Paul TOTH There is however question of usage frequency. If called too often that might pose a problem. But I haven't looked at that code closely.

    ReplyDelete
  13. Paul TOTHJune 11, 2017 at 4:10 AM

    Dalija Prasnikar the variable is used by CreateRegionDataFromBitmap called only by CreateRegionFromBitmap, called only by TWindowBorderWin.RecreateRegion, called only by TWindowBorderWin.Resize...not sure what it is about...
    docwiki.embarcadero.com - FMX.Forms.TForm.Border - RAD Studio API Documentation

    ReplyDelete
  14. Dalija PrasnikarJune 11, 2017 at 5:16 AM

    Paul TOTH Regions are used to define window shape (form or any other win control). There are several API functions to do that - most simple are rectangle and round rectangle regions.

    For more complex, irregular shapes you have to define it by array of rectangles. And you have to do that every time window changes its size.

    So when you drag to resize above functions will be repeatedly called during that process. So speed counts. If nothing else globally defined fixed size array is allocated only once.

    Again, I haven't looked at that code closely so I don't know how well it is written and I don't know what are possible bottlenecks there.

    ReplyDelete
  15. Dalija PrasnikarJune 11, 2017 at 5:52 AM

    Attila Kovacs Multithreading is not an issue because this is UI related code.

    ReplyDelete

Post a Comment