The best way to solve issues with menus, in my view, is not to custom draw them at all. You remove all the custom draw code, and you make sure that the MENUITEMINFO struct has a PARGB32 hbmpItem.
Thank you Uwe! Well done! This sad story tells me once again that Emba is unwilling or unable to solve the most simple problems in a timely manner. The cash of money (maintenance contracts) always works very well. I do not give this company much time!
So are embarcadero going to take them on board for an update or next version? For those of us that use runtime packages and can't just patch the vcl. Marco Cantu ?
Uwe Raabe For people who don't use Delphi 10.2 Tokyo, is it possible to apply the same high DPI techniques to the VCL you discovered at runtime using delphi-detours-library?
Edwin Yip Actually I cannot answer this question. If you have access to the 10.2.3 sources you can apply the patches and try to backport them to your Delphi version. Given the amount of work needed to get all this working in the first place, I am not willing to invest any more time to support older Delphi versions. Also I am not sure if all that is required can be done with Detours.
Vincent Parrett and Uwe Raabe We plan incorporating the patches -- or augment them if needed -- for the next release. As for Ralf Stocker comment, we wish we could be faster, but respecting the intellectual property of our MVPs and any other potential contributors is important.
Marco Cantù Any chance that you could consider the approach I outlined whereby you could throw away all of your themed custom draw code and let the system do it?
Marko Hietanen This can't be done with Delphi 10.2, because it is an interface breaking change. Unfortunately we have to wait for 10.3 to get this integrated.
/sub
ReplyDeleteThe best way to solve issues with menus, in my view, is not to custom draw them at all. You remove all the custom draw code, and you make sure that the MENUITEMINFO struct has a PARGB32 hbmpItem.
ReplyDeleteThank you Uwe! Well done! This sad story tells me once again that Emba is unwilling or unable to solve the most simple problems in a timely manner. The cash of money (maintenance contracts) always works very well. I do not give this company much time!
ReplyDeleteSo are embarcadero going to take them on board for an update or next version? For those of us that use runtime packages and can't just patch the vcl. Marco Cantu ?
ReplyDeleteUwe Raabe For people who don't use Delphi 10.2 Tokyo, is it possible to apply the same high DPI techniques to the VCL you discovered at runtime using delphi-detours-library?
ReplyDeleteVincent Parrett They have the patches, but I cannot say what they are going to do with them.
ReplyDeleteEdwin Yip Actually I cannot answer this question. If you have access to the 10.2.3 sources you can apply the patches and try to backport them to your Delphi version. Given the amount of work needed to get all this working in the first place, I am not willing to invest any more time to support older Delphi versions. Also I am not sure if all that is required can be done with Detours.
ReplyDeleteVincent Parrett and Uwe Raabe We plan incorporating the patches -- or augment them if needed -- for the next release. As for Ralf Stocker comment, we wish we could be faster, but respecting the intellectual property of our MVPs and any other potential contributors is important.
ReplyDeleteMarco Cantù Any chance that you could consider the approach I outlined whereby you could throw away all of your themed custom draw code and let the system do it?
ReplyDeleteHi Marco, I see solving bugs as a task of the developers of Emba and not of the MVPs.
ReplyDeleteHi, How long we need to wait? Please release small patch soon. Ps. Thank you Uwe.
ReplyDeleteMarko Hietanen This can't be done with Delphi 10.2, because it is an interface breaking change. Unfortunately we have to wait for 10.3 to get this integrated.
ReplyDeleteUwe Raabe Thanks for all your hard work with this. The patches work great on my end.
ReplyDeleteAre all of your patches included in 10.3?
ReplyDeleteDominic De Chasteigner Dumée Some are left out and others are implemented differently.
ReplyDelete