I could use some input on https://gist.github.com/jpluimers/b08b65991987d01e1dd1bdb4bf8a33c4
I could use some input on https://gist.github.com/jpluimers/b08b65991987d01e1dd1bdb4bf8a33c4
Especially on:
- the abstracting of the non-UI logic from https://github.com/pleriche/FastMM4/blob/master/Demos/Usage%20Tracker/FastMMUsageTracker.pas
- the conversion to JSON: built-in Delphi JSON support does not do records out of the box, but I feel my workaround is cumbersome.
There is an example on how to use it for logging memory and processor usage on the console.
If you have an account at Delphi Praxis, you can also comment at
- https://en.delphipraxis.net/topic/206-please-shoot-at-memorymanagerunitpas-that-abstracts-some-non-ui-logic-from-fastmmusagetrackerpas
- https://www.delphipraxis.net/198488-bitte-schiessen-memorymanagerunit-pas-das-einige-nicht-ui-logik-abstrahiert.html
https://gist.github.com/jpluimers/b08b65991987d01e1dd1bdb4bf8a33c4
Especially on:
- the abstracting of the non-UI logic from https://github.com/pleriche/FastMM4/blob/master/Demos/Usage%20Tracker/FastMMUsageTracker.pas
- the conversion to JSON: built-in Delphi JSON support does not do records out of the box, but I feel my workaround is cumbersome.
There is an example on how to use it for logging memory and processor usage on the console.
If you have an account at Delphi Praxis, you can also comment at
- https://en.delphipraxis.net/topic/206-please-shoot-at-memorymanagerunitpas-that-abstracts-some-non-ui-logic-from-fastmmusagetrackerpas
- https://www.delphipraxis.net/198488-bitte-schiessen-memorymanagerunit-pas-das-einige-nicht-ui-logik-abstrahiert.html
https://gist.github.com/jpluimers/b08b65991987d01e1dd1bdb4bf8a33c4
I'm all for it. I like your idea of splitting that logic out of the UI parts.
ReplyDeleteUnrelated to your changes, I realized I had made a bunch of changes to the Usage Tracker to better support 64bit. A lot of it still relied on DWORD types for things that should have been 64bit. I just made a Pull request against the FastMM github. It's my first ever time using Git/Pull requests (I'm an SVN guy), so hopefully I did it correctly.
Brian Ford thanks. I was not aware you wrote that code in the first place (:
ReplyDeleteFound the pull request: github.com - Better support for 64bit in Usage Tracker. by brianjford · Pull Request #62 · pleriche/FastMM4
I think your pull request does not affect the abstraction I did.
Do you think it does?
If not, I will try to refactor your UI to use my abstraction.
I did not write the usage tracker. I hope I didn't give that impression.. I am using that code in one of my projects and made those 64bit changes a long time ago for my own use. Figured I should give it back to the community incase anyone else is using the usage tracker.
ReplyDelete